MartijnVisser commented on code in PR #306:
URL:
https://github.com/apache/flink-connector-kafka/pull/306#discussion_r4351951483
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/dynamic/source/DynamicKafkaSourceBuilder.java:
##########
@@ -279,7 +280,8 @@ private void setRequiredConsumerProperties() {
KafkaSourceOptions.CLIENT_ID_PREFIX.key(),
props.containsKey(ConsumerConfig.GROUP_ID_CONFIG)
? props.getProperty(ConsumerConfig.GROUP_ID_CONFIG)
- : "DynamicKafkaSource-" +
RandomStringUtils.randomAlphabetic(8),
+ : "DynamicKafkaSource-"
+ +
StringUtils.generateRandomAlphanumericString(new Random(), 8),
Review Comment:
Every test in `DynamicKafkaSourceBuilderTest` goes through this branch, but
none checks the value. Asserting it matches `DynamicKafkaSource-[A-Za-z0-9]{8}`
would cover the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
