MartijnVisser commented on code in PR #29568: URL: https://github.com/apache/flink/pull/29568#discussion_r4360394074
########## .mvn/wrapper/maven-wrapper.properties: ########## @@ -16,7 +16,7 @@ # under the License. # updating the Maven version requires updates to certain documentation and verification logic +wrapperVersion=3.3.4 +distributionType=only-script Review Comment: The e2e jobs don't run in the image, so they still download the 3.9.16 zip on every run. Can we change that as part of this PR? ########## .mvn/wrapper/maven-wrapper.properties: ########## @@ -16,7 +16,7 @@ # under the License. # updating the Maven version requires updates to certain documentation and verification logic +wrapperVersion=3.3.4 +distributionType=only-script distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.16/apache-maven-3.9.16-bin.zip distributionSha256Sum=5af3b743dd8b876b5c45da33b676251e5f1687712644abb4ee519ca56e1d89ce Review Comment: Without `unzip`, mvnw switches to the .tar.gz but still checks it against this .zip checksum and fails with "might be compromised" (apache/maven-wrapper#425). Might make sense to add `unzip` to the README prerequisites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
