MartijnVisser commented on code in PR #335:
URL:
https://github.com/apache/flink-connector-kafka/pull/335#discussion_r4362944168
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/sink/KafkaSinkITCase.java:
##########
@@ -539,11 +538,7 @@ public void checkMigration(
clusterClient);
JobResult jobResult = clusterClient.requestJobResult(thirdJobId).get();
- assertThat(jobResult.getApplicationStatus())
- .isEqualTo(
- supportedMigration
- ? ApplicationStatus.SUCCEEDED
- : ApplicationStatus.FAILED);
+ assertThat(jobResult.isSuccess()).isEqualTo(supportedMigration);
Review Comment:
Same meaning here. `isSuccess()` is true for `SUCCEEDED` on 2.2 and
`FINISHED` on 2.3. In the unsupported case it would also accept `CANCELED`, but
the `else` branch then asserts the root cause of the throwable, and `JobResult`
only carries one for `FAILED`.
##########
flink-connector-kafka/src/test/java/org/apache/flink/streaming/connectors/kafka/table/KafkaTableTestBase.java:
##########
@@ -106,6 +107,17 @@ void after() {
cancelTimeoutLogger();
}
+ /**
+ * Since Flink 2.3 (FLIP-558), an insert whose upsert key differs from the
primary key of the
Review Comment:
Yes. 2.3 treats a query without an upsert key as one whose upsert key
differs from the primary key, and none of these inserts has one. Without the
clause, 23 of the 30 tests in these two classes fail on 2.3.0. I've reworded
the Javadoc to say so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
