wenjin272 commented on PR #1312: URL: https://github.com/apache/flink-agents/pull/1312#issuecomment-6379268373
Thanks again for the fix, @wank125! With the 0.4 release process starting on Monday, I pushed two follow-up commits to this branch to address the remaining review feedback and keep release preparation moving. Both commits include you as a co-author. The changes are: - Require an explicit key selector for Table input in both Java and Python, remove Java's identity-key fallback, and add Table contract tests. - Align the Java review examples around product IDs: deserialize JSON into `ProductReview` upstream for the single-agent/YAML examples, pass `ProductReviewSummary` directly from the multi-agent window to the suggestion agent, and key the ReAct Row input by `id`. - Generate valid JSON when constructing prompts, and synchronize the four Quickstart pages, integration guide, and API documentation. Validation passed: 34 focused Java tests, 35 Python remote-environment tests, formatting and documentation checks, plus live runs of all four Java examples against local Ollama. The multi-agent example's existing final partial-window limitation with bounded input remains unchanged. The follow-up commits are `bbb61b30f` and `b3276f9c0`. Please take a look when you have a chance—feedback and further adjustments are very welcome! Generated-by: Codex CLI 0.153.4 (GPT-6) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
