leonardBang commented on code in PR #4593:
URL: https://github.com/apache/flink-cdc/pull/4593#discussion_r4367291881
##########
.github/workflows/build_docs.yml:
##########
@@ -72,9 +89,24 @@ jobs:
echo "flink_alias=stable" >> ${GITHUB_ENV}
fi
+ - name: Build Docusaurus site
+ if: hashFiles('docs/package.json') != ''
+ run: |
+ npm --prefix docs install --package-lock=false
Review Comment:
Would it make sense to commit a `package-lock.json` and use `npm ci` here
and in the PR check? With `--package-lock=false`, each PR check and scheduled
deployment resolves transitive dependencies afresh. A dependency release could
then make the daily docs build fail or produce a different site without any
change in this repository, even if the PR check passed with a different
dependency tree. Pinning the resolved tree would make these builds reproducible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
