MartijnVisser commented on code in PR #338:
URL:
https://github.com/apache/flink-connector-kafka/pull/338#discussion_r4371166235
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/sink/internal/FlinkKafkaInternalProducer.java:
##########
@@ -203,7 +204,7 @@ private void flushNewPartitions() {
TransactionalRequestResult result = enqueueNewPartitions();
Object sender = getField("sender");
invoke(sender, "wakeup");
- result.await();
+ result.await(Long.MAX_VALUE, TimeUnit.MILLISECONDS, "flushing new
partitions");
Review Comment:
With this, the exactly-once sink needs `kafka-clients` 4.3.0 or later. Can
you add that to the Release Note field on the Jira?
##########
pom.xml:
##########
@@ -54,7 +54,7 @@ under the License.
<!-- Main Dependencies -->
<confluent.version>7.9.2</confluent.version>
<flink.version>2.2.1</flink.version>
- <kafka.version>4.2.0</kafka.version>
+ <kafka.version>4.4.0</kafka.version>
Review Comment:
Please also bump the NOTICE of `flink-sql-connector-kafka` (CI's license
check flags it) and `APACHE_KAFKA` in `DockerImageVersions`, as FLINK-39120 did.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
