Github user wangzhijiang999 commented on the issue:

    https://github.com/apache/flink/pull/3151
  
    @tillrohrmann . Thank you for detail review and comments!
    
    This PR just submit the heartbeat logic in TM side, because there is 
already a jira of JM heartbeat side.
    
    For my implementation, the JM initiates the heartbeat with 
**HeartbeatManagerSenderImpl** and the TM responses the heartbeat with 
**HeartbeatManagerImpl**. So the heartbeat process is one-way.
    
    I think it is better to submit the JM heartbeat logic in this PR in order 
to understand easily. I will modify this PR soon, and for testing there already 
exists the UT for basic heartbeat logic. Do you mean to add some ITCases?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to