laughingman7743 commented on code in PR #1222:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1222#discussion_r4400951734
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/FlinkConfigBuilder.java:
##########
@@ -546,7 +546,13 @@ private String getStandaloneJarURI(JobSpec jobSpec) throws
URISyntaxException {
private int getParallelism() {
if (spec.getTaskManager() != null &&
spec.getTaskManager().getReplicas() != null) {
if (spec.getJob().getParallelism() > 0) {
- LOG.warn("Job parallelism setting is ignored as TaskManager
replicas are set");
+ if (!effectiveConfig.get(
Review Comment:
Thank you for the review! You are right, this is meant only for standalone
mode. Native mode already covers the standby use case with
`slotmanager.redundant-taskmanager-num`, so I have added the
`KubernetesDeploymentMode.STANDALONE.equals(spec.getMode())` check here as you
suggested. I also updated the warning, the option description and the docs to
say that the option has no effect in native mode, and added a native mode case
to `FlinkConfigBuilderTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
