MartijnVisser commented on code in PR #29557: URL: https://github.com/apache/flink/pull/29557#discussion_r4424055781
########## flink-runtime-web/src/main/resources/META-INF/NOTICE: ########## @@ -263,7 +264,251 @@ OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. --- -@angular/[email protected] +@angular/[email protected] Review Comment: The two extra `@angular/core` blocks are the MCP licences of type declarations Angular vendors under `third_party/`. None of it ends up in the bundle, so these can go. ########## flink-runtime-web/web-dashboard/src/app/pages/job/checkpoints/job-checkpoints.component.html: ########## @@ -387,7 +387,7 @@ <nz-collapse-panel [nzHeader]="'Percentiles'" [nzActive]="moreDetailsPanel.active" - [nzDisabled]="moreDetailsPanel.disabled" + [nzCollapsible]="moreDetailsPanel.disabled ? 'disabled' : undefined" Review Comment: `moreDetailsPanel.disabled` is never set to true, so this binding can go, here and in the rescales page. ########## flink-runtime-web/pom.xml: ########## @@ -273,7 +273,7 @@ under the License. <goal>install-node-and-npm</goal> </goals> <configuration> - <nodeVersion>v22.16.0</nodeVersion> + <nodeVersion>v22.22.3</nodeVersion> Review Comment: Node 22 is EOL end of April 2027, and Angular 22 also supports ^24.15. Might make sense to go to 24 directly? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
