MartijnVisser commented on code in PR #29701: URL: https://github.com/apache/flink/pull/29701#discussion_r4427963415
########## tools/ci/maven-utils.sh: ########## @@ -76,7 +76,9 @@ MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR+="-Dmaven.wagon.http.pool=false " MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR+="-Daether.connector.basic.threads=16 " # fetch POMs in parallel while collecting dependencies (default collector "df" is sequential) MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR+="-Daether.dependencyCollector.impl=bf -Daether.dependencyCollector.bf.threads=16 " -# logging +# git-commit-id-plugin: native git is much faster than JGit on the full-history checkout; CI images have git Review Comment: It's not the history: JGit fetches origin for ahead/behind on every build, native git skips that on a detached HEAD. ########## tools/ci/maven-utils.sh: ########## @@ -76,7 +76,9 @@ MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR+="-Dmaven.wagon.http.pool=false " MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR+="-Daether.connector.basic.threads=16 " # fetch POMs in parallel while collecting dependencies (default collector "df" is sequential) MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR+="-Daether.dependencyCollector.impl=bf -Daether.dependencyCollector.bf.threads=16 " -# logging +# git-commit-id-plugin: native git is much faster than JGit on the full-history checkout; CI images have git +MVN_GLOBAL_OPTIONS_WITHOUT_MIRROR+="-Dmaven.gitcommitid.nativegit=true " Review Comment: I think `includeOnlyProperties` with the four keys we read gets the same win locally too, and keeps JGit: native git silently leaves the revision unset when the repo owner differs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
