MartijnVisser opened a new pull request, #29717:
URL: https://github.com/apache/flink/pull/29717
## What is the purpose of the change
Supersedes #21760, which targeted release-1.16 and only fixed the missing
`val`, and #28826, which only fixes the stray parentheses. The other temporal
table function examples fail to compile or fail validation on master.
## Brief change log
- First commit is #21760 by its author, moved to the page's current
location
- Pass expressions to `createTemporalTableFunction`, alias the table
function in the SQL join, and use the page's columns in the Java and Scala joins
- Same expression fix in the temporal join example in `tableApi.md`, and
join on `o_proctime` there
- Same changes in the Chinese pages
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Ran every changed example from both languages against a master build. The
joins on the temporal table function page return 5676 with the page's data, and
the `tableApi.md` example runs.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
