manish1337 commented on PR #29614: URL: https://github.com/apache/flink/pull/29614#issuecomment-6558665020
@snuyanzin thanks for filing CALCITE-7909! 1. Agree the real fix belongs in Calcite, but Flink only picks it up after a Calcite upgrade, and until then these queries return wrong rows. So I'd keep this as a temporary override and drop it once CALCITE-7909 is in. Happy to help on the Calcite side too. 2. Permutations are pushed down again now. Anything else stays above, since dropping or rewriting a field changes which rows match. The class is only there for the `matches()` check; I can switch to two configured instances of the Calcite rule if you prefer. 3. Replaced the ITCases with semantic tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
