snuyanzin commented on code in PR #29723:
URL: https://github.com/apache/flink/pull/29723#discussion_r4436427281
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinToMultiJoinForReorderRule.java:
##########
@@ -645,23 +646,42 @@ private RexNode shiftRightFilter(
}
/**
- * Combines the post-join filters from the left and right inputs (if they
are MultiJoinRels)
- * into a single AND'd filter.
+ * Combines the post-join filters from the left and right inputs (if they
are MultiJoinRels
+ * combined into the new MultiJoin) into a single AND'd filter. A
MultiJoin that isn't combined,
+ * e.g. the null generating input of an outer join, stays an input of the
new MultiJoin and
+ * keeps its post-join filter, so the filter must not be applied above the
new MultiJoin, too.
*
* @param joinRel the original LogicalJoin
* @param left left child of the LogicalJoin
* @param right right child of the LogicalJoin
* @return combined post-join filters AND'd together
*/
- private List<RexNode> combinePostJoinFilters(Join joinRel, RelNode left,
RelNode right) {
+ private List<RexNode> combinePostJoinFilters(
+ Join joinRel, RelNode left, RelNode right, List<Boolean>
inputNullGenFieldList) {
Review Comment:
javadoc is invalid after that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
