wenjin272 commented on PR #1347: URL: https://github.com/apache/flink-agents/pull/1347#issuecomment-6570625864
Thanks for working on this! We clarified the intended behavior in [[#1337](https://github.com/apache/flink-agents/pull/1337#discussion_r4419831489)](https://github.com/apache/flink-agents/pull/1337#discussion_r4419831489): - Flink 1.20: prefer `flink-conf.yaml`, falling back to `config.yaml`. - Flink 2.x: read only `config.yaml`. - Parse `flink-conf.yaml` using legacy rules matching Flink’s `GlobalConfiguration.loadLegacyYAMLResource()`, and `config.yaml` using standard YAML rules. This PR still uses `yaml.safe_load()` for both files. Adding support for flat `agent.*` keys does not address legacy parsing compatibility, such as literal values containing `: `. I’d prefer handling Java and Python together in #1337 to keep their behavior consistent. A separate Python PR is also fine if coordinated with that author, but it should follow the same file-selection and parsing rules. Could you coordinate with the author of #1337 on the scope? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
