snuyanzin commented on code in PR #29690:
URL: https://github.com/apache/flink/pull/29690#discussion_r4452581601
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/data/utils/FromVariantConverter.java:
##########
@@ -131,9 +131,9 @@ private static ValueReader createReader(
{
final int length = LogicalTypeChecks.getLength(type);
final boolean charTarget = type.is(LogicalTypeRoot.CHAR);
+ final TimeZone timeZone =
TimeZone.getTimeZone(sessionZone);
return variant ->
- VariantCastUtils.toStringValue(
- variant, sessionZone, length, charTarget);
+ VariantCastUtils.toStringValue(variant, timeZone,
length, charTarget);
Review Comment:
is there a reason `toStringValue` takes `timeZone`, while others take
`ZoneId`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
