Github user tonycox commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3205#discussion_r100156082
  
    --- Diff: flink-contrib/docker-flink/Dockerfile ---
    @@ -36,22 +31,25 @@ ENV PATH $PATH:$FLINK_HOME/bin
     EXPOSE 8081
     EXPOSE 6123
     
    +# flink-dist can point to a directory, a tarball on the local system, or a 
url to a tarball
    +ARG flink_dist=NOT_SET
    +
     # Install build dependencies and flink
    +ADD $flink_dist $FLINK_INSTALL_PATH
     RUN set -x && \
       mkdir -p $FLINK_INSTALL_PATH && \
    --- End diff --
    
    and what if `$flink_dist` is url ? 
    Should run `tar xzf` I think


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to