snuyanzin commented on code in PR #27577:
URL: https://github.com/apache/flink/pull/27577#discussion_r4473782507


##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/RegexpInputTypeStrategy.java:
##########
@@ -57,10 +57,14 @@ public ArgumentCount getArgumentCount() {
     @Override
     public Optional<List<DataType>> inferInputTypes(
             final CallContext callContext, final boolean throwOnFailure) {
-        if (STRING_ARG.inferArgumentType(callContext, ARG_STR, 
throwOnFailure).isEmpty()) {
+        final Optional<DataType> strType =

Review Comment:
   why do we need to touch strategy which is shared with `REGEXP`?
   can we just use generic? similar way it is done for `SPLIT` function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to