applike-ss commented on code in PR #1163:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1163#discussion_r4465825690
##########
helm/flink-kubernetes-operator/templates/cert-manager/certificate.yaml:
##########
@@ -45,5 +45,5 @@ spec:
kind: Issuer
name: flink-operator-selfsigned-issuer
commonName: FlinkDeployment Validator
- secretName: webhook-server-cert
+ secretName: flink-operator-webhook-server-cert
Review Comment:
I see the point, however cert manager should be running all the time -
unless you have a very volatile cluster in terms of your nodes, but even then
it should schedule quickly and pick up its work again.
So yes, a GitOps tool would temporarily fail to create or update flink
kubernetes operator resources - once during this upgrade for a bit longer than
usual. I don't see this to be a problem though, since hacking to gether an
option for a one-time shorter downtime doesn't seem worth it.
I did however add notes in the documentation about the secret name change
and the implications this has, also for removing the original secret which
could be used by other operators too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
