spuru9 commented on code in PR #29008:
URL: https://github.com/apache/flink/pull/29008#discussion_r4496960654


##########
flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/AbstractHistoryServerHandler.java:
##########
@@ -347,6 +348,9 @@ private Entry loadResource(
                             jobArchiveMetaInfo == null ? null : 
jobArchiveMetaInfo.getArchivePath();
                     archiveFetcher.lazyFetchArchiveProactively(jobId, 
archivePath);
                 }
+                if (archiveFetcher.getArchiveMetaInfo(jobId) != null) {

Review Comment:
   major: Jobs outside `cached-retained-jobs` never load in the dashboard. The 
job page's first call is `/jobs/<id>`, and for `jobs/<id>.json` `extractJobId` 
returns `<id>.json`, so nothing gets fetched and it 404s, leaving the page 
stuck on the loading skeleton. It only works once something like 
`/jobs/<id>/config` has fetched the job, so opening these jobs by URL as the 
docs describe doesn't really work from the UI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to