HsbcJone commented on PR #1352: URL: https://github.com/apache/flink-agents/pull/1352#issuecomment-6676004808
Thanks @wenjin272 — review feedback is addressed on `e963cca` (logic/docs/rename). Spotless/AOSP wrap fixed in `fc43b709`; `spotless:check` plus `RequestContextTest` / `BuiltInEventsTest` passed locally. Per-thread mapping: - **[Array copy](https://github.com/apache/flink-agents/pull/1352#discussion_r4488469434):** `UserDefinedContext.snapshot` recursively copies object/primitive arrays (incl. nested in lists). Test `nestedArrayIsCopiedSoLaterMutationDoesNotChangeAnEarlierRequest` covers `String[]`, `int[]`, nested `String[]`. - **[Rename to userContext](https://github.com/apache/flink-agents/pull/1352#discussion_r4488469438):** All eight request/response events use `userContext` / Python `user_context`; key `user_context`; accessors `getUserContext()` / `user_context`. - **[Drop request-side withContext()](https://github.com/apache/flink-agents/pull/1352#discussion_r4488469442):** Request events take the map only in the constructor; `withUserContext()` remains on the four response events. - **[chat.md](https://github.com/apache/flink-agents/pull/1352#discussion_r4488469445):** Describes app-defined data request→response; links Serialization/Typed Values and User context. - **[events.md serialization](https://github.com/apache/flink-agents/pull/1352#discussion_r4488469447):** Points at Serialization/Typed Values; JSON may change runtime types; construction copies mutable structure only. - **[events.md opening](https://github.com/apache/flink-agents/pull/1352#discussion_r4488469454):** Leads with carrying application-defined data; removed “existing callers” / attachments comparison. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
