Dennis-Mircea opened a new pull request, #1251:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1251
## What is the purpose of the change
This PR fixes the log levels and messages of the reconciler layer. Decisions
that change the cluster were logged at `debug`, a few messages were misleading
or duplicated, and "JobManager" was spelled three ways. No behaviour change.
## Brief change log
- JobManager recovery
(`AbstractFlinkResourceReconciler.shouldRecoverDeployment`): the missing
Deployment is a `warn`, the recovery is an `info` naming its reason (stateless
job, or HA enabled), the refusal names its reason. Javadoc corrected, HA is
required only for stateful jobs.
- Unhealthy job restart
(`ApplicationReconciler.shouldRestartJobBecauseUnhealthy`): decision at `info`
with its reason, refusal at `warn`.
- Job ID (`ApplicationReconciler.setJobIdIfNecessary`): new `info` when
the ID comes from the spec, "Generated job ID", and an `info` "Deploying with
job ID" for every deploy.
- Messages: the upgrade summary no longer claims a reason the branches
above it already logged. The two identical "Waiting for pending cancellation"
lines in `SessionJobReconciler` now tell apart "already in progress" and
"triggered". The retry counter in `ReconciliationUtils` says what it counts.
"Not ready to serve requests", "does not contain", "Unknown savepoint state" at
`warn`, and "JobManager Deployment" everywhere.
## Verifying this change
These new logs can be verified in normal reconciliation flows.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please
change the checkbox below to `[X]` followed by the name of the tool, and
uncomment the
"Generated-by" line. See the ASF Generative Tooling Guidance for details:
https://www.apache.org/legal/generative-tooling.html
You are responsible for the quality and correctness of every change in this
PR
regardless of the tooling used. Low-effort AI-generated PRs will be closed.
See
AGENTS.md for the full guidance.
-->
- [ ] Yes (please specify the tool below)
<!--
Generated-by: [Tool Name and Version]
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
