litiliu commented on code in PR #4608:
URL: https://github.com/apache/flink-cdc/pull/4608#discussion_r4510006327
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-fluss/src/main/java/org/apache/flink/cdc/connectors/fluss/source/event/TableSubscriptionEvent.java:
##########
@@ -35,21 +36,20 @@ public class TableSubscriptionEvent implements SourceEvent {
private final Set<TablePath> subscribedTablePaths;
private final Map<TablePath, Long> pendingRemovalRequests;
private final Set<TablePath> fencedTablePaths;
-
- public TableSubscriptionEvent(
- Set<TablePath> subscribedTablePaths, Map<TablePath, Long>
pendingRemovalRequests) {
- this(subscribedTablePaths, pendingRemovalRequests,
Collections.emptySet());
- }
+ private final Set<PhysicalTablePath> subscribedPhysicalTablePaths;
Review Comment:
Thanks for the suggestion, @loserwang1024. I've folded the runtime cleanup
from #4609 into this PR and extended the existing table-removal request/ACK
lifecycle to partition removals, so recovery and runtime discovery now share
the same cleanup flow. I've also added the corresponding IT coverage and
squashed the changes into one commit.
Could you please take another look when you have a chance? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
