sangkyoonnam commented on code in PR #29601:
URL: https://github.com/apache/flink/pull/29601#discussion_r4511899929
##########
flink-python/pyflink/datastream/tests/test_data_stream.py:
##########
@@ -1088,6 +1088,42 @@ def test_collection_type_info(self):
" 2021-01-09 12:00:00.011, [1, 2, 3]]"]
self.assert_equals_sorted(expected, results)
+ def test_value_state_update_none(self):
Review Comment:
Rebased onto master and replaced the IT case with unit tests in
`test_state_impl.py`, following #29599. `SynchronousValueRuntimeStateTests`
covers `update(None)` clearing both pending and committed values, a repeated
`update(None)` on empty state, and a new value after `None`. Those three fail
without the fix; `test_non_none_updates_preserve_zero_and_replacement` covers
the non-`None` path and passes either way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
