manner commented on code in PR #29520:
URL: https://github.com/apache/flink/pull/29520#discussion_r4512734919
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -3264,6 +3266,16 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
.runtimeProvided()
.build();
+ public static final BuiltInFunctionDefinition XML_STRING =
+ BuiltInFunctionDefinition.newBuilder()
+ .name("XML_STRING")
+ .kind(SCALAR)
+
.inputTypeStrategy(sequence(logical(LogicalTypeRoot.VARIANT)))
+
.outputTypeStrategy(nullableIfArgs(explicit(DataTypes.STRING())))
+ .runtimeClass(
+
"org.apache.flink.table.runtime.functions.scalar.XmlStringFunction")
Review Comment:
Yeah, no code-gen here. For the JSON/XML parsing we want to reuse the same
input between calls with different paths. Here, there's only a single parameter
to the function, so there's nothing to share. Expression reuse will handle the
case when the function is called with exactly the same parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
