sangkyoonnam commented on PR #1362: URL: https://github.com/apache/flink-agents/pull/1362#issuecomment-6736942865
Thanks @wenjin272. Both points are addressed in follow-up commits. 11181ea4 adds `model_routing_test.py`, which runs a Flink job with a Python agent that declares two routers over mock chat models. The five inputs cover a rule selection, the default when no rule matches, fallback from a candidate that always fails, and a custom executor that selects on one input and abstains on another. Each answer names the model that produced it, and the output also checks `selected_model`, `final_model`, `decision_source` and `fallback_models_tried` from `model_routing`. c634e93f removes the separate Python section. Registration, rules, custom executor, calling a router and reading the routing attribute now use Python/Java tabs, and shared behavior is described once. The persistence keys and the Java validation path are gone; the Python tab only states that patterns must also be valid Java regular expressions. LLM judge and decision model now say Python doesn't support them yet, and the all-candidates-fail row describes each language's error. I also merged main to resolve the conflict with #1352. The routed path now passes `user_context` to the strategy-failure and all-candidates-fail responses, and f2712861 adds Python tests for those paths plus fallback followed by a tool round, matching the Java cases #1352 added. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
