MartijnVisser commented on code in PR #29832:
URL: https://github.com/apache/flink/pull/29832#discussion_r4517851621
##########
pom.xml:
##########
@@ -1886,6 +1884,12 @@ under the License.
<requireJavaVersion>
<version>${target.java.version}</version>
</requireJavaVersion>
+ <!-- Hadoop
before 3.4.3 fails on Java 23+ (HADOOP-19212) -->
+
<requireProperty>
+
<property>flink.hadoop.version</property>
+
<regex>^(3\.4\.([3-9]|[1-9][0-9]+)|3\.([5-9]|[1-9][0-9]+)\.[0-9]+|([4-9]|[1-9][0-9]+)\.[0-9]+\.[0-9]+)([.-].*)?$</regex>
+
<regexMessage>flink.hadoop.version must be 3.4.3 or later.</regexMessage>
+
</requireProperty>
Review Comment:
If we do that, users can't pass through custom versions of Hadoop from other
vendors, which I think for Hadoop is a typical thing
(https://mvnrepository.com/artifact/org.apache.hadoop/hadoop-common/versions
shows Cloudera, Hortonworks and like 10 more)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
