MartijnVisser commented on code in PR #258:
URL:
https://github.com/apache/flink-connector-jdbc/pull/258#discussion_r4537427024
##########
flink-connector-jdbc-core/src/main/java/org/apache/flink/connector/jdbc/core/datastream/sink/writer/JdbcWriter.java:
##########
@@ -142,6 +143,9 @@ public void write(IN element, Context context) throws
IOException, InterruptedEx
@Override
public void flush(boolean endOfInput) throws IOException,
InterruptedException {
+ if (endOfInput) {
Review Comment:
Same thing in practice, `SinkWriterOperator` never calls `flush(false)`
after `endInput()`. I kept the latch so a direct caller can't reset it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
