pranavshuklaa commented on code in PR #1091:
URL: https://github.com/apache/flink-agents/pull/1091#discussion_r4543807208
##########
api/src/main/java/org/apache/flink/agents/api/configuration/AgentConfigOptions.java:
##########
@@ -208,6 +208,37 @@ public enum ConditionEvaluationFailureStrategy {
public static final ConfigOption<Integer> TRACE_LOG_MAX_DEPTH =
new ConfigOption<>("trace-log.standard.max-depth", Integer.class,
5);
+ /**
+ * The maximum number of bytes accepted from a single skill archive
download over HTTP(S). Must
+ * be strictly positive; there is no unlimited setting. Defaults to 64 MiB.
+ */
+ public static final ConfigOption<Long> SKILL_SOURCE_URL_MAX_DOWNLOAD_BYTES
=
+ new ConfigOption<>(
+ "skill.source.url.max-download-bytes", Long.class, 64L *
1024 * 1024);
+
+ /**
+ * The maximum uncompressed size in bytes of a single entry when a skill
archive is extracted.
+ * Must be strictly positive; there is no unlimited setting. Defaults to
64 MiB.
+ */
+ public static final ConfigOption<Long>
SKILL_SOURCE_URL_MAX_EXTRACT_ENTRY_BYTES =
+ new ConfigOption<>(
+ "skill.source.url.max-extract-entry-bytes", Long.class,
64L * 1024 * 1024);
Review Comment:
Done. `SkillOptions` is in `api/skills` (Java) and
`flink_agents/api/skills.py` (Python) with `URL_MAX_DOWNLOAD_BYTES`,
`MAX_EXTRACT_ENTRY_BYTES`, `MAX_EXTRACT_TOTAL_BYTES` and `MAX_EXTRACT_ENTRIES`.
The keys are `skill.source.url.max-download-bytes` and
`skill.source.max-extract-{entry-bytes,total-bytes,entries}`.
`AgentConfigOptions` is back to its `main` version in both languages. I updated
`configuration.md` and added the `SkillOptions` pair to the parity check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
