weiqingy opened a new pull request, #29889:
URL: https://github.com/apache/flink/pull/29889
## What is the purpose of the change
`RestoreTestBase` and `CommonSemanticTestBase` switch the values source to
per-record watermarks for any source that declares a watermark, because
processing-time watermark emission makes time-based tests flaky. Both detected
the watermark with a case-sensitive `startsWith("WATERMARK FOR")`, so the 23
schema components that write `WATERMARK for` or `watermark for` silently ran
with periodic watermark emission instead. That affects 18 restore test classes
and 2 semantic test classes, listed in FLINK-41445.
## Brief change log
- Detect the watermark declaration case-insensitively in
`RestoreTestBase#enablePerRecordWatermarks` and
`CommonSemanticTestBase#createSourceOptions`.
## Verifying this change
This change is already covered by existing tests. All 20 affected classes
pass against the committed plans and savepoints (143 tests, 0 failures), so no
test files need to be regenerated. A temporary print inside the check confirmed
that it now matches the lower-case sources in `IntervalJoinRestoreTest` and
`WindowJoinSemanticTests`, which it did not match before.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code 2.1.322 (Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
