spuru9 commented on code in PR #272:
URL:
https://github.com/apache/flink-connector-jdbc/pull/272#discussion_r4548353533
##########
flink-connector-jdbc-postgres/src/test/java/org/apache/flink/connector/jdbc/postgres/datastream/sink/PostgresJdbcSinkITCase.java:
##########
@@ -43,8 +43,8 @@
import static org.apache.flink.connector.jdbc.JdbcTestFixture.TEST_DATA;
import static org.assertj.core.api.Assertions.assertThat;
-/** Test for backward compatibility. */
-public class DataStreamSinkTest implements PostgresTestBase {
+/** The {@link JdbcSink} ITCase for PostgreSQL, at-least-once and
exactly-once. */
+class PostgresJdbcSinkITCase implements PostgresTestBase {
Review Comment:
```suggestion
class PostgresJdbcSinkITCase implements PostgresTestBase, JdbcITCaseBase {
```
optional nit: JdbcITCaseBase already registers this exact MiniCluster, and
PostgresCatalogTestBase in this module uses it. We can let go of MINI_CLUSTER
then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
