fresh-borzoni commented on code in PR #28090:
URL: https://github.com/apache/flink/pull/28090#discussion_r4563287864
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/PushFilterIntoSourceScanRuleBase.java:
##########
@@ -87,12 +94,28 @@ protected FilterPushDownResult classifyAndPushFilters(
boolean supportsMetadataFilter =
canPushdownMetadataFilter(tableSourceTable);
List<String> metadataKeys = getReadMetadataKeys(tableSourceTable);
int firstMetadataIndex = scan.getRowType().getFieldCount() -
metadataKeys.size();
+ Set<ImmutableBitSet> keys =
getUpsertKeysOfUpdatingSource(tableSourceTable, scan);
Review Comment:
Makes sense, but I kept the changelog mode check: a scan's upsert keys don't
depend on its changelog mode, so without it insert-only sources would keep
non-key filters in a Calc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
