[
https://issues.apache.org/jira/browse/FLINK-4364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861562#comment-15861562
]
ASF GitHub Bot commented on FLINK-4364:
---------------------------------------
Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3151
@tillrohrmann , I have submitted the updates that may cover your
suggestions.
There are still two issues that I am not confirmed.
First, for heartbeat interval and timeout default values in
**ConfigConstants**, they are not invalid currently and you can modify it with
your professional experience.
Second, the introduction of **ScheduledExecutorService** in **RPCService**,
my initial idea is trying to use the existing scheduler in **RPCService**, but
it can not be got from **AkkaRPCService** implementation. Another way is to
replace the current **ScheduledExecutorService** parameter with **RPCService**
in construction of **HeartbeatManagerSenderImpl**, and the **RPCService** can
also schedule the heartbeat request. But the return value of
**scheduleRunnable** method in **RPCService** is conflict with that in
**HeartbeatManagerSenderImpl**. So I just bring another single thread pool in
**RPCService** for use currently. Maybe the number of threads in pool can refer
to number of cpu cores.
Maybe there are still something to be polished, and I am willing for
further modifications by your comments.
BTW, the heartbeat interaction between TM and RM will be submitted in
another PR after this confirmation because of some common points.
> Implement TaskManager side of heartbeat from JobManager
> -------------------------------------------------------
>
> Key: FLINK-4364
> URL: https://issues.apache.org/jira/browse/FLINK-4364
> Project: Flink
> Issue Type: Sub-task
> Components: Cluster Management
> Reporter: Zhijiang Wang
> Assignee: Zhijiang Wang
>
> The {{JobManager}} initiates heartbeat messages via (JobID, JmLeaderID), and
> the {{TaskManager}} will report metrics info for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
