Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3176#discussion_r101247688
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -220,56 +247,105 @@ class CodeGenerator(
// manual casting here
val samHeader =
// FlatMapFunction
- if (clazz == classOf[FlatMapFunction[_,_]]) {
+ if (clazz == classOf[FlatMapFunction[_, _]]) {
--- End diff --
As I mentioned above, why not keeping it simple and always generate
RichFunctions? The `clazz` parameter is still correct as `RichFlatMapFunction`
implements `FlatMapFunction`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
