[ 
https://issues.apache.org/jira/browse/FLINK-5751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871107#comment-15871107
 ] 

ASF GitHub Bot commented on FLINK-5751:
---------------------------------------

Github user patricklucas commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3332#discussion_r101678631
  
    --- Diff: docs/check_links.sh ---
    @@ -0,0 +1,39 @@
    +#!/usr/bin/env bash
    
+################################################################################
    +#  Licensed to the Apache Software Foundation (ASF) under one
    +#  or more contributor license agreements.  See the NOTICE file
    +#  distributed with this work for additional information
    +#  regarding copyright ownership.  The ASF licenses this file
    +#  to you under the Apache License, Version 2.0 (the
    +#  "License"); you may not use this file except in compliance
    +#  with the License.  You may obtain a copy of the License at
    +#
    +#      http://www.apache.org/licenses/LICENSE-2.0
    +#
    +#  Unless required by applicable law or agreed to in writing, software
    +#  distributed under the License is distributed on an "AS IS" BASIS,
    +#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +#  See the License for the specific language governing permissions and
    +# limitations under the License.
    
+################################################################################
    +
    +# Don't abort on any non-zero exit code
    +#set +e
    +
    +target=${1:-"http://localhost:4000"}
    +
    +# Crawl the docs, ignoring robots.txt, storing nothing locally
    +wget --spider -r -nd -nv -e robots=off -p -o spider.log $target
    +
    +# Abort for anything other than 0 and 4 ("Network failure")
    +status=$?
    +if [ $status -ne 0 ] && [ $status -ne 4 ]; then
    +    exit $status
    +fi
    +
    +# Fail the build if any broken links are found
    +broken_links_str=$(grep -e 'Found [[:digit:]]\+ broken link' spider.log)
    +echo -e "$broken_links_str"
    --- End diff --
    
    If you're going to get rid of my pretty bold-red formatting you can drop 
the `-e` too. :)
    
    Actually, might as well put the `echo` line inside the `if` too.


> 404 in documentation
> --------------------
>
>                 Key: FLINK-5751
>                 URL: https://issues.apache.org/jira/browse/FLINK-5751
>             Project: Flink
>          Issue Type: Bug
>          Components: Documentation
>            Reporter: Colin Breame
>            Priority: Trivial
>             Fix For: 1.3.0, 1.2.1
>
>
> This page:
> https://ci.apache.org/projects/flink/flink-docs-release-1.2/quickstart/setup_quickstart.html
> Contains a link with title "Flink on Windows" with URL:
> - 
> https://ci.apache.org/projects/flink/flink-docs-release-1.2/setup/flink_on_windows
> This gives a 404.  It should be:
> - 
> https://ci.apache.org/projects/flink/flink-docs-release-1.2/setup/flink_on_windows.html



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to