[ 
https://issues.apache.org/jira/browse/FLINK-5414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15871622#comment-15871622
 ] 

ASF GitHub Bot commented on FLINK-5414:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3338#discussion_r101728056
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/ExpressionReducer.scala
 ---
    @@ -106,8 +106,16 @@ class ExpressionReducer(config: TableConfig)
             case SqlTypeName.ANY | SqlTypeName.ROW | SqlTypeName.ARRAY =>
               reducedValues.add(unreduced)
             case _ =>
    +          val reducedValue = reduced.getField(reducedIdx)
    +          // RexBuilder handle boolean literal incorrectly, convert it 
into BigDecimal manually
    --- End diff --
    
    Can you check the comment? Shouldn't "boolean" be "double"?


> Bump up Calcite version to 1.11
> -------------------------------
>
>                 Key: FLINK-5414
>                 URL: https://issues.apache.org/jira/browse/FLINK-5414
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Timo Walther
>            Assignee: Jark Wu
>
> The upcoming Calcite release 1.11 has a lot of stability fixes and new 
> features. We should update it for the Table API.
> E.g. we can hopefully merge FLINK-4864



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to