Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3346#discussion_r101760988
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointCoordinator.java
---
@@ -296,15 +298,42 @@ public boolean isShutdown() {
checkNotNull(targetDirectory, "Savepoint target directory");
CheckpointProperties props =
CheckpointProperties.forStandardSavepoint();
- CheckpointTriggerResult result = triggerCheckpoint(timestamp,
props, targetDirectory, false);
- if (result.isSuccess()) {
- return
result.getPendingCheckpoint().getCompletionFuture();
- }
- else {
- Throwable cause = new Exception("Failed to trigger
savepoint: " + result.getFailureReason().message());
- return
FlinkCompletableFuture.completedExceptionally(cause);
+ // Create the unique savepoint directory
+ final String savepointDirectory = SavepointStore
--- End diff --
We could also not create the directory here, but instead simply create the
path name and send it to the tasks.
@StephanEwen Maybe creating directories like these is something we should
keep in mind for the state backends on the JobManager?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
