[
https://issues.apache.org/jira/browse/FLINK-5838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872400#comment-15872400
]
ASF GitHub Bot commented on FLINK-5838:
---------------------------------------
GitHub user greghogan opened a pull request:
https://github.com/apache/flink/pull/3352
[FLINK-5838] [scripts] Print shell script usage
If jobmanager.sh, taskmanager.sh, or zookeeper.sh are called without
arguments then argument list for the call to flink-daemon.sh is misaligned and
the usage for flink-daemon displayed to the user.
Adds a check to each script to check for a valid action and otherwise
displays the proper usage string.
Note: this PR conflicts with the PR for FLINK-4326 which adds a
"start-foreground" action.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/greghogan/flink 5838_print_shell_script_usage
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3352.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3352
----
commit 0441164935a34032523040864ec18ee01b4adb5b
Author: Greg Hogan <c...@greghogan.com>
Date: 2017-02-17T19:38:31Z
[FLINK-5838] [scripts] Print shell script usage
If jobmanager.sh, taskmanager.sh, or zookeeper.sh are called without
arguments then argument list for the call to flink-daemon.sh is
misaligned and the usage for flink-daemon displayed to the user.
Adds a check to each script to check for a valid action and otherwise
displays the proper usage string.
----
> Print shell script usage
> ------------------------
>
> Key: FLINK-5838
> URL: https://issues.apache.org/jira/browse/FLINK-5838
> Project: Flink
> Issue Type: Bug
> Components: Startup Shell Scripts
> Affects Versions: 1.3.0
> Reporter: Greg Hogan
> Assignee: Greg Hogan
> Priority: Trivial
> Fix For: 1.3.0
>
>
> {code}
> $ ./bin/jobmanager.sh
> Unknown daemon ''. Usage: flink-daemon.sh (start|stop|stop-all)
> (jobmanager|taskmanager|zookeeper) [args].
> {code}
> The arguments in {{jobmanager.sh}}'s call to {{flink-daemon.sh}} are
> misaligned when {{$STARTSTOP}} is the null string.
> {code}
> "${FLINK_BIN_DIR}"/flink-daemon.sh $STARTSTOP jobmanager "${args[@]}"
> {code}
> Same issue in {{taskmanager.sh}} and {{zookeeper.sh}}.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
