Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3336#discussion_r102162632
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/DefaultKeyedStateStore.java
 ---
    @@ -93,6 +95,18 @@ public DefaultKeyedStateStore(KeyedStateBackend<?> 
keyedStateBackend, ExecutionC
                }
        }
     
    +   @Override
    +   public <UK, UV> MapState<UK, UV> getMapState(MapStateDescriptor<UK, UV> 
stateProperties) {
    +           requireNonNull(stateProperties, "The state properties must not 
be null");
    +           try {
    +                   
stateProperties.initializeSerializerUnlessSet(executionConfig);
    +                   MapState<UK, UV> originalState = 
getPartitionedState(stateProperties);
    +                   return new UserFacingMapState<>(originalState);
    +           } catch (Exception e) {
    +                   throw new RuntimeException("Error while getting state", 
e);
    --- End diff --
    
    What I meant was using a more specific subclass of `RuntimeException` (e.g. 
`IllegalAccess`,`IllegalState`, `IndexOutOfBounds`, etc.) that better reflects 
the error, but still can leave the method signature unchanged.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to