[ 
https://issues.apache.org/jira/browse/FLINK-5812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15876173#comment-15876173
 ] 

ASF GitHub Bot commented on FLINK-5812:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/3328
  
    Yes, it was accidentally merged together with another PR.
    Since the changes were mostly comments and annotations, it should not be a 
problem.
    
    Closing...


> Clean up FileSystem
> -------------------
>
>                 Key: FLINK-5812
>                 URL: https://issues.apache.org/jira/browse/FLINK-5812
>             Project: Flink
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 1.2.0
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Minor
>             Fix For: 1.3.0
>
>
> The {{FileSystem}} class is overloaded and has methods that are not well 
> supported. I suggest to do the following cleanups:
>   - Pull the safety net into a separate class
>   - Use the {{WriteMode}} to indicate overwriting behavior. Right now, the 
> {{FileSystem}} class defines that enum and never uses it. It feels weird.
>   - Remove the {{create(path, overwrite, blocksize, reolication, ...)}} 
> method, which is not really supported across file system implementations. For 
> HDFS, behavior should be set via the configuration anyways.
> All changes have to be made in a non-API-breaking fashion.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to