[
https://issues.apache.org/jira/browse/FLINK-5767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878164#comment-15878164
]
ASF GitHub Bot commented on FLINK-5767:
---------------------------------------
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3354#discussion_r102455635
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/builtInAggFuncs/AggFunctionTestBase.scala
---
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.table.functions.builtInAggFuncs
+
+import org.apache.flink.table.functions.{Accumulator, AggregateFunction}
+import java.math.BigDecimal
+
+import org.apache.flink.table.functions.utils.UserDefinedFunctionUtils._
+import org.apache.flink.types.Row
+import org.junit.Test
+import org.junit.Assert.assertEquals
+
+/**
+ * Base class for aggregate function test
+ *
+ * @tparam T the type for the aggregation result
+ */
+abstract class AggFunctionTestBase[T] {
+ private val offset = 2
--- End diff --
None of the tests uses `offset`, `numOfAggregates`, and `rowArity` or `Row`.
I think the tests can be simplified by removing these and the methods
`getResult()` (directly call `getValue()`) and `mergeRows()` (directly call
`merge()`).
> New aggregate function interface and built-in aggregate functions
> -----------------------------------------------------------------
>
> Key: FLINK-5767
> URL: https://issues.apache.org/jira/browse/FLINK-5767
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Shaoxuan Wang
> Assignee: Shaoxuan Wang
>
> Add a new aggregate function interface. This includes implementing the
> aggregate interface, migrating the existing aggregation functions to this
> interface, and adding the unit tests for these functions.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
