Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3354#discussion_r102693561
--- Diff:
flink-libraries/flink-table/src/test/scala/org/apache/flink/table/functions/aggfunctions/AggFunctionTestBase.scala
---
@@ -56,11 +53,15 @@ abstract class AggFunctionTestBase[T] {
if (ifMethodExitInFunction("merge", aggregator)) {
// iterate over input sets
- for((vals, expected) <- inputValueSets.zip(expectedResults)) {
+ for ((vals, expected) <- inputValueSets.zip(expectedResults)) {
val (firstVals, secondVals) = vals.splitAt(vals.length / 2)
--- End diff --
In addition to splitting the `vals` data set, we should also test
correctness, if we merge with an empty accumulator, i.e., aggregate all `vals`
into one accumulator and merge it with an empty one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
