[ https://issues.apache.org/jira/browse/FLINK-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880775#comment-15880775 ]
ASF GitHub Bot commented on FLINK-4754: --------------------------------------- Github user StephanEwen commented on the issue: https://github.com/apache/flink/pull/3374 I think having it only in the configuration is probably fine. I think we do not need both paths here. Illegal values are probably checked when creating the recovery factory. It would be nice to have a "configuration validator" early, but we do not have something like that currently. > Make number of retained checkpoints user configurable > ----------------------------------------------------- > > Key: FLINK-4754 > URL: https://issues.apache.org/jira/browse/FLINK-4754 > Project: Flink > Issue Type: Improvement > Components: State Backends, Checkpointing > Affects Versions: 1.1.2 > Reporter: Ufuk Celebi > Assignee: Wei-Che Wei > > The number of retained successful checkpoints is fixed to 1. Expose this > setting via the {{CheckpointConfig}} instead of having it fixed as a static > field in the {{CheckpointRecoveryFactory}}. > With the current state of things, this would require to set this value lazily > in the checkpoint store implementations instead of setting it when creating > the store. -- This message was sent by Atlassian JIRA (v6.3.15#6346)