[
https://issues.apache.org/jira/browse/FLINK-5133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885784#comment-15885784
]
ASF GitHub Bot commented on FLINK-5133:
---------------------------------------
Github user zhijiangW commented on the issue:
https://github.com/apache/flink/pull/3303
Hi @StephanEwen , thanks for detail reviews of this PR and I learnt a lot
from your comments.
I considered all your suggestions above and submitted the modifications,
including:
1. Comment out to remove **setters** which would be exposed to users and
just keep the **getters**.
2. Use **preferredResource** instead of **maxResource** in order not to
confuse users.
3. Use **@Nullable** annotation for some variables.
4. Distinguish between **checkNotNull** and **checkArgument**.
5. Modifications in scala-like way, consider the
**BatchScalaAPICompletenessTest** and **StreamingScalaAPICompletenessTest**,
some methods should be the same between java and scala.
BTW, after this PR merge, I would submit the blocked codes related with
**JobGraph** generation and runtime stack.
> Support to set resource for operator in DataStream and DataSet
> --------------------------------------------------------------
>
> Key: FLINK-5133
> URL: https://issues.apache.org/jira/browse/FLINK-5133
> Project: Flink
> Issue Type: Sub-task
> Components: DataSet API, DataStream API
> Reporter: zhijiang
> Assignee: zhijiang
>
> This is part of the fine-grained resource configuration.
> For *DataStream*, the *setResource* API will be setted onto
> *SingleOutputStreamOperator* similar with other existing properties like
> parallelism, name, etc.
> For *DataSet*, the *setResource* API will be setted onto *Operator* in the
> similar way.
> There are two parameters described with minimum *ResourceSpec* and maximum
> *ResourceSpec* separately in the API for considering resource resize in
> future improvements.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
