[ 
https://issues.apache.org/jira/browse/FLINK-5776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885917#comment-15885917
 ] 

ASF GitHub Bot commented on FLINK-5776:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3418#discussion_r103206923
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/MapRunner.scala
 ---
    @@ -41,7 +43,13 @@ class MapRunner[IN, OUT](
         LOG.debug(s"Compiling MapFunction: $name \n\n Code:\n$code")
         val clazz = compile(getRuntimeContext.getUserCodeClassLoader, name, 
code)
         LOG.debug("Instantiating MapFunction.")
    -    function = clazz.newInstance()
    +    if (null == parameterValues || null == parameterTypes) {
    --- End diff --
    
    Same as `FlatMapRunner`


> Improve XXMapRunner support create instance by carrying constructor parameters
> ------------------------------------------------------------------------------
>
>                 Key: FLINK-5776
>                 URL: https://issues.apache.org/jira/browse/FLINK-5776
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> At present, MapRunner FlatMapRunner only supports create non-parameter 
> instance, but sometimes we need to carry constructor parameters to 
> instantiate, so I would like to improve XXMapRunner support create instance 
> by carrying constructor parameters.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to