Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3418#discussion_r103226511
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/CodeGenerator.scala
---
@@ -1562,6 +1561,39 @@ class CodeGenerator(
}
/**
+ * Adds a reusable constructor statement with the given parameter types,
+ * and the member variable's name that stores the variables passed in
the constructor.
+ *
+ * @param memberVariables The member variable's name that stores the
variables passed in
+ * the constructor.
+ * @param parameterTypes The parameter types to construct the function
+ */
+ def addReusableConstructorWithMemberVariables(
--- End diff --
This method is basically doing the same as `addReusableConstructor` except
that it allows to hardcode the names of the member variables. The same
functionality (in a safe manner) can be achieved by reusing existing code, IMO.
For instance, the code of the test could be rewritten to:
```
val params = generator.addReusableConstructor(classOf[Long])
val card = params(0)
val body =
s"""
|return java.lang.Long.valueOf(in1) +
java.lang.Long.valueOf($card);
""".stripMargin
```
We would have to remove the `null` assignment for the initially empty field
variable in `addReusableConstructor` though (or check if it is a primitive
type).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
