[
https://issues.apache.org/jira/browse/FLINK-5090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892336#comment-15892336
]
ASF GitHub Bot commented on FLINK-5090:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r103936964
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -389,11 +389,20 @@ public Task(
++counter;
}
+ invokableHasBeenCanceled = new AtomicBoolean(false);
+
+ // finally, create the executing thread, but do not start it
+ executingThread = new Thread(TASK_THREADS_GROUP, this,
taskNameWithSubtask);
+
+ // add metrics for buffers
+ this.metrics.getIOMetricGroup().initializeBufferMetrics(this);
+
// register detailed network metrics, if configured
if
(tmConfig.getBoolean(TaskManagerOptions.NETWORK_DETAILED_METRICS_KEY)) {
- MetricGroup networkGroup =
metricGroup.addGroup("Network"); // same as in
MetricUtils.instantiateNetworkMetrics()
- MetricGroup outputGroup =
networkGroup.addGroup("Output"); // this is optional
- MetricGroup inputGroup =
networkGroup.addGroup("Input"); // this is optional
+ // similar to MetricUtils.instantiateNetworkMetrics()
but inside this IOMetricGroup
+ MetricGroup networkGroup =
this.metrics.getIOMetricGroup().addGroup("Network");
--- End diff --
this is equivalent to ```metricGroup.addGroup("Network")```. The
IOMetricGroup is just a proxy that forwards calls to the parent group, i.e. the
task metric group.
> Expose optionally detailed metrics about network queue lengths
> --------------------------------------------------------------
>
> Key: FLINK-5090
> URL: https://issues.apache.org/jira/browse/FLINK-5090
> Project: Flink
> Issue Type: New Feature
> Components: Metrics, Network
> Affects Versions: 1.1.3
> Reporter: Stephan Ewen
> Assignee: Stephan Ewen
>
> For debugging purposes, it is important to have access to more detailed
> metrics about the length of network input and output queues.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
