[ 
https://issues.apache.org/jira/browse/FLINK-5107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15892658#comment-15892658
 ] 

ASF GitHub Bot commented on FLINK-5107:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2837#discussion_r103984233
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/JobManagerOptions.java
 ---
    @@ -0,0 +1,38 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.jobmanager;
    +
    +import org.apache.flink.annotation.PublicEvolving;
    +import org.apache.flink.configuration.ConfigOption;
    +
    +import static org.apache.flink.configuration.ConfigOptions.key;
    +
    +@PublicEvolving
    +public class JobManagerOptions {
    +
    +   /**
    +    * The maximum number of prior execution attempts kept in history.
    +    */
    +   public static final ConfigOption<Integer> MAX_ATTEMPTS_HISTORY_SIZE =
    +                   
key("job-manager.max-attempts-history-size").defaultValue(16);
    --- End diff --
    
    This key deviates from the existing job manager config constants, which all 
start with "jobmanager". Is this intended?


> Job Manager goes out of memory from long history of prior execution attempts
> ----------------------------------------------------------------------------
>
>                 Key: FLINK-5107
>                 URL: https://issues.apache.org/jira/browse/FLINK-5107
>             Project: Flink
>          Issue Type: Bug
>          Components: JobManager
>            Reporter: Stefan Richter
>            Assignee: Stefan Richter
>
> We have observed that the job manager can run out of memory during long 
> running jobs with many vertexes. Analysis of the heap dump shows, that the 
> ever-growing history of prior execution attempts is the culprit for this 
> problem.
> We should limit this history to a number of n most recent attempts. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to