Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3391#discussion_r103204770
  
    --- Diff: flink-core/src/main/java/org/apache/flink/util/NetUtils.java ---
    @@ -383,4 +424,8 @@ public static String getWildcardIPAddress() {
        public interface SocketFactory {
                ServerSocket createSocket(int port) throws IOException;
        }
    +
    +   public interface ServerFactory<T> {
    +           T create(String address, int port) throws Exception;
    --- End diff --
    
    Java docs are missing. You should document that a `BindException` will be 
ignored and all other exception will cause the `createServerFromPorts` method 
to fail.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to