Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3304#discussion_r104158582
  
    --- Diff: 
flink-yarn/src/main/java/org/apache/flink/yarn/YarnResourceManager.java ---
    @@ -245,7 +248,7 @@ public void onContainersAllocated(List<Container> 
containers) {
                        try {
                                /** Context information used to start a 
TaskExecutor Java process */
                                ContainerLaunchContext 
taskExecutorLaunchContext =
    -                                           
createTaskExecutorLaunchContext(container.getResource(), 
container.getId().toString(), container.getNodeId().getHost());
    +                                           
createTaskExecutorLaunchContext(container.getResource(), 
container.getId().toString(), container.getNodeId().getHost(), 
container.getPriority());
    --- End diff --
    
    Yes, but this should not be a problem. I think the resource manager should 
be able to deal with this kind of scenario. For example, if the allocated 
container offers more resources than requested, it could in the future also be 
used to fulfill other slot request which require more resources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to