[ 
https://issues.apache.org/jira/browse/FLINK-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15894531#comment-15894531
 ] 

ASF GitHub Bot commented on FLINK-5916:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3415#discussion_r104170895
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
 ---
    @@ -360,6 +360,7 @@ public static String getTaskManagerShellCommand(
                                                        "-Xmx" + 
tmParams.taskManagerHeapSizeMB() + "m " +
                                                        
"-XX:MaxDirectMemorySize=" + tmParams.taskManagerDirectMemoryLimitMB() + "m");
                String javaOpts = 
flinkConfig.getString(CoreOptions.FLINK_JVM_OPTIONS);
    +           javaOpts += " " + 
flinkConfig.getString(CoreOptions.FLINK_TM_JVM_OPTIONS);
    --- End diff --
    
    Can we only add it if the config string is non-empty?


> make env.java.opts.jobmanager and env.java.opts.taskmanager working in YARN 
> mode
> --------------------------------------------------------------------------------
>
>                 Key: FLINK-5916
>                 URL: https://issues.apache.org/jira/browse/FLINK-5916
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN
>            Reporter: Tao Wang
>            Assignee: Tao Wang
>
> Now only env.java.opts works in YARN mode, and it applies both to JM and TM. 
> I'd like to make env.java.opts.jobmanager and env.java.opts.taskmanager 
> working in YARN mode in addition,  to support fine grained params setting.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to